Skip to content

8340146: ZGC: TestAllocateHeapAt.java should not run with UseLargePages #3724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

8340146: ZGC: TestAllocateHeapAt.java should not run with UseLargePages #3724

wants to merge 2 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jul 9, 2025 •
edited by openjdk bot
Loading

I backport this for parity with 17.0.17-oracle.

Omitted the test file that came with generational zgc.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8340146 needs maintainer approval

Issue

  • JDK-8340146: ZGC: TestAllocateHeapAt.java should not run with UseLargePages (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3724/head:pull/3724
$ git checkout pull/3724

Update a local copy of the PR:
$ git checkout pull/3724
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3724/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3724

View PR using the GUI difftool:
$ git pr show -t 3724

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3724.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 9, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 9, 2025 •
edited
Loading

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340146: ZGC: TestAllocateHeapAt.java should not run with UseLargePages

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title backport 4098acc200e608369ac1631dcc8513ea797bd59e 8340146: ZGC: TestAllocateHeapAt.java should not run with UseLargePages Jul 9, 2025
@openjdk
Copy link

openjdk bot commented Jul 9, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 9, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 9, 2025 •
edited
Loading

Webrevs

MBaesken
MBaesken reviewed Jul 11, 2025
View reviewed changes
Copy link
Member

@MBaesken MBaesken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test/hotspot/jtreg/gc/z/TestAllocateHeapAt.java is also in 17 (and was changed in 21) why is it not in?

@GoeLin
Copy link
Member Author

GoeLin commented Jul 11, 2025

Hi @MBaesken
thanks for catching this!
I added the missing edits. I also reran the test, it passes.

@openjdk
Copy link

openjdk bot commented Jul 11, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jul 12, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Jul 14, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jul 14, 2025

Going to push as commit 560e765.
Since your change was applied there have been 25 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 14, 2025
@openjdk openjdk bot closed this Jul 14, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 14, 2025
@openjdk
Copy link

openjdk bot commented Jul 14, 2025

@GoeLin Pushed as commit 560e765.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8340146 branch July 14, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBaesken MBaesken MBaesken approved these changes

Assignees
No one assigned
Labels
backport integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GoeLin @MBaesken